Skip to content

Add solution for Project Euler problem 188 #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 21, 2020
Merged

Add solution for Project Euler problem 188 #2880

merged 8 commits into from
Nov 21, 2020

Conversation

darkstar
Copy link
Contributor

@darkstar darkstar commented Oct 5, 2020 •
edited
Loading

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

dhruvmanila
dhruvmanila requested changes Oct 6, 2020
View reviewed changes
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR require type hints https://docs.python.org/3/library/typing.html labels Oct 6, 2020
@darkstar
Copy link
Contributor Author

I updated everything with the requested changes from #2875 which probably apply here as well, even though not explicitly stated

@darkstar darkstar requested a review from Kush1101 as a code owner October 12, 2020 20:20
@darkstar
Copy link
Contributor Author

This should address all requested changes now

@darkstar darkstar mentioned this pull request Oct 12, 2020
Merged
14 tasks
@darkstar
Copy link
Contributor Author

darkstar commented Oct 12, 2020 •
edited
Loading

Why is this failing in a file that I didn't even change?

pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/quantum/single_qubit_measure.py b/quantum/single_qubit_measure.py
index 99d807b..7f058c2 100755
--- a/quantum/single_qubit_measure.py
+++ b/quantum/single_qubit_measure.py
@@ -1,7 +1,7 @@
 #!/usr/bin/env python3
 """
...

dhruvmanila
dhruvmanila reviewed Oct 15, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Announcement:

@darkstar

This message is sent to all pull requests which are OPEN, NOT MERGED, not containing 'wontfix' label and contains 'Project Euler' or 'Project' or 'Euler' (case doesn't matter) in their title. If this message doesn't apply to your pull request, please ignore this.

Message:

This is to notify all the users submitting a pull request for the Project Euler solution that the README.md file has been updated with all the style requirements necessary for the directory and solution files. Please read through it and make all the necessary changes required to your submission.

@stale
Copy link

stale bot commented Nov 21, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@dhruvmanila
Copy link
Member

Remove the label.

@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 21, 2020
@dhruvmanila dhruvmanila reopened this Nov 21, 2020
@dhruvmanila dhruvmanila added awaiting changes A maintainer has requested changes to this PR and removed require type hints https://docs.python.org/3/library/typing.html awaiting changes A maintainer has requested changes to this PR labels Nov 21, 2020
dhruvmanila
dhruvmanila approved these changes Nov 21, 2020
View reviewed changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and for your persistence!

@ghost ghost removed the awaiting changes A maintainer has requested changes to this PR label Nov 21, 2020
@dhruvmanila dhruvmanila merged commit d0bc9e2 into TheAlgorithms:master Nov 21, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
@darkstar @stokhos
Add solution for Project Euler problem 188 (TheAlgorithms#2880)
b7a7506 
* Project Euler problem 188 solution

* fix superscript notation

* split out modexpt() function, and rename parameters

* Add some more doctest, and add type hints

* Add some reference links

* Update docstrings and mark helper function private

* Fix doctests and remove/improve redundant comments

* fix as per style guide
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
@darkstar @peRFectBeliever
Add solution for Project Euler problem 188 (TheAlgorithms#2880)
53f3a41 
* Project Euler problem 188 solution

* fix superscript notation

* split out modexpt() function, and rename parameters

* Add some more doctest, and add type hints

* Add some reference links

* Update docstrings and mark helper function private

* Fix doctests and remove/improve redundant comments

* fix as per style guide
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
@darkstar
Add solution for Project Euler problem 188 (TheAlgorithms#2880)
dd13e77 
* Project Euler problem 188 solution

* fix superscript notation

* split out modexpt() function, and rename parameters

* Add some more doctest, and add type hints

* Add some reference links

* Update docstrings and mark helper function private

* Fix doctests and remove/improve redundant comments

* fix as per style guide
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
@darkstar @shermanhui
Add solution for Project Euler problem 188 (TheAlgorithms#2880)
dd3bd9d 
* Project Euler problem 188 solution

* fix superscript notation

* split out modexpt() function, and rename parameters

* Add some more doctest, and add type hints

* Add some reference links

* Update docstrings and mark helper function private

* Fix doctests and remove/improve redundant comments

* fix as per style guide
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila approved these changes

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darkstar @dhruvmanila